[Kde-games-devel] Review Request 109565: Bug 188413 - out-of-bounds array index when trying to generate solvable board

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109565/#review29467
-----------------------------------------------------------


Agreed, it doesn't crash, but it does not show the same if I open it with the Board Editor, so maybe you can have a look at the Board Editor and get the code improvements from there?

- Albert Astals Cid


On March 18, 2013, 4:14 p.m., Ian Simpson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109565/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 4:14 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Added bounds checking in GameData::onlyFreeInLine()
> 
> 
> This addresses bug 188413.
>     http://bugs.kde.org/show_bug.cgi?id=188413
> 
> 
> Diffs
> -----
> 
>   GameData.cpp 3867b10 
> 
> Diff: http://git.reviewboard.kde.org/r/109565/diff/
> 
> 
> Testing
> -------
> 
> Successfully loaded the heart.layout attached by bug reporter.
> 
> 
> Thanks,
> 
> Ian Simpson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130318/bbc005d1/attachment.html>