[Kde-games-devel] Review Request 109365: Support for QtQuick in libkdegames

[Viranch Mehta]

> On March 14, 2013, 7:23 p.m., Albert Astals Cid wrote:
> > declarativeimports/qml/KgItem.qml, line 21
> > <http://git.reviewboard.kde.org/r/109365/diff/2/?file=119153#file119153line21>
> >
> >     Could you explain how you do the fallback magic here? Or it needs code in the application?

I'll try:

So we have two images for each KgItem: one on top of the other. the one on the top is the image who's 'source' gets updated on resize/themechange. as soon as this happens, the top image goes invisible until the new sprite is rendered. as long as it remains invisible, the image at its bottom becomes visible (this image is the fallback). the fallback image has latest sprite that was rendered in the image at the top. (this is done by connecting top image's onStatusChanged signal to: if (status==Ready) bottomImage.source = topImage.source; status=Ready means the sprite was rendered). so when top image's rendering is complete, it will become visible again, and the bottom image will take the just-rendered sprite in itself from the cache (because bottomImage.source=topImage.source and topImage is already in cache as it was just rendered). so when top image goes invisible again (due to an update in 'source'), the bottom image will keep being displayed until the top image finishes rendering and is shown back.

Yesterday I committed a change where we don't need to necessarily show the top image, it will stay invisible, trigger new rendering requests on resize/themechange, and the bottom image will update only when the requested rendering is complete - so it will never go invisible, not even while its being rendered.


- Viranch


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109365/#review29223
-----------------------------------------------------------


On March 11, 2013, 5:50 a.m., Viranch Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109365/
> -----------------------------------------------------------
> 
> (Updated March 11, 2013, 5:50 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> This is a copy of review request #7017 in SVN review board because I needed to update the patch (it won't accept git diffs). Updated description:
> 
> This patch contains support for QtQuick in libkdegames for future porting QML. Post this patch, libkdeclarative becomes a dependency for libkdegames.
> 
> We have some new classes:
> 
> 1. KgImageProvider:
> This is a QDeclarativeImageProvider, and a sort-of replacement for KGameRenderer for QML ports. This class is supplied with a KgThemeProvider which it uses to discover SVG locations, reads them using QSvgRenderer and returns the requested sprite pixmap. QDeclarativeImageProvider has inbuilt ability of caching and asynchronous loading of pixmaps, which is why can replace usages of KGameRenderer in QML ports.
> 
> 2. KgDeclarativeView:
> This is a QDeclarativeView with KDE-specific import paths for QML components configured and javascript functions bindings added (like i18n() methods) using the KDeclarative library. Game's KgThemeProviders are supplied to this class which in turn registers them with the underlying QML engine, and adds KgImageProviders corresponding to each KgThemeProvider.
> 
> 3. KgItem QML component:
> This is simple QML Image element wrapper for showing sprites on QML views using the KgImageProviders. We specify which one of the KgImageProviders we want to use and which sprite key we want to show, and it will be painted on the view.
> 
> The patch may not stay up-to-date, relevant code is in "viranch/qtquick" branch in libkdegames's git repo.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 67b8b40 
>   declarativeimports/CMakeLists.txt PRE-CREATION 
>   declarativeimports/corebindingsplugin.h PRE-CREATION 
>   declarativeimports/corebindingsplugin.cpp PRE-CREATION 
>   declarativeimports/qml/KgItem.qml PRE-CREATION 
>   declarativeimports/qml/qmldir PRE-CREATION 
>   includes/CMakeLists.txt 8756a50 
>   includes/KgDeclarativeView PRE-CREATION 
>   kgdeclarativeview.h PRE-CREATION 
>   kgdeclarativeview.cpp PRE-CREATION 
>   kgimageprovider.h PRE-CREATION 
>   kgimageprovider.cpp PRE-CREATION 
>   kgthemeprovider.h 6ca9b63 
>   kgthemeprovider.cpp e186106 
> 
> Diff: http://git.reviewboard.kde.org/r/109365/diff/
> 
> 
> Testing
> -------
> 
> I'm using KBreakout to test all of this. The relevant port can be found in "qtquick/imageprovider" branch in KBreakout's git repo.
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130315/5bc9d5d1/attachment.html>