[Kde-games-devel] Review Request 109365: Support for QtQuick in libkdegames

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109365/#review29223
-----------------------------------------------------------


Looks good :-) most of the comments are simply spacing or style 


declarativeimports/qml/KgItem.qml
<http://git.reviewboard.kde.org/r/109365/#comment21831>

    Could you explain how you do the fallback magic here? Or it needs code in the application?



kgdeclarativeview.h
<http://git.reviewboard.kde.org/r/109365/#comment21820>

    const & for the name



kgimageprovider.cpp
<http://git.reviewboard.kde.org/r/109365/#comment21822>

    const



kgimageprovider.cpp
<http://git.reviewboard.kde.org/r/109365/#comment21823>

    const



kgimageprovider.cpp
<http://git.reviewboard.kde.org/r/109365/#comment21824>

    const



kgimageprovider.cpp
<http://git.reviewboard.kde.org/r/109365/#comment21825>

    As far as i remember creating a QSvgRenderer was quite expensive, you may want to check if it still is and instead of creating it every time, create it just once in the constructor



kgimageprovider.cpp
<http://git.reviewboard.kde.org/r/109365/#comment21826>

    this
    }
    else {
    looks like should be
    } else {
    ?



kgimageprovider.cpp
<http://git.reviewboard.kde.org/r/109365/#comment21827>

    Seems like you could simply do
    image.fill(Qt::transparent);
    ?



kgthemeprovider.h
<http://git.reviewboard.kde.org/r/109365/#comment21816>

    You spacing is off, you can see it clearly if you look at the file in reviewboard, probably spaces vs tabs



kgthemeprovider.h
<http://git.reviewboard.kde.org/r/109365/#comment21829>

    Need documentation for these (and the rest of functions you added) and @since markers
    
    



kgthemeprovider.h
<http://git.reviewboard.kde.org/r/109365/#comment21817>

    Add & here



kgthemeprovider.h
<http://git.reviewboard.kde.org/r/109365/#comment21830>

    This should a private slot not part of the public api


- Albert Astals Cid


On March 11, 2013, 5:50 a.m., Viranch Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109365/
> -----------------------------------------------------------
> 
> (Updated March 11, 2013, 5:50 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> This is a copy of review request #7017 in SVN review board because I needed to update the patch (it won't accept git diffs). Updated description:
> 
> This patch contains support for QtQuick in libkdegames for future porting QML. Post this patch, libkdeclarative becomes a dependency for libkdegames.
> 
> We have some new classes:
> 
> 1. KgImageProvider:
> This is a QDeclarativeImageProvider, and a sort-of replacement for KGameRenderer for QML ports. This class is supplied with a KgThemeProvider which it uses to discover SVG locations, reads them using QSvgRenderer and returns the requested sprite pixmap. QDeclarativeImageProvider has inbuilt ability of caching and asynchronous loading of pixmaps, which is why can replace usages of KGameRenderer in QML ports.
> 
> 2. KgDeclarativeView:
> This is a QDeclarativeView with KDE-specific import paths for QML components configured and javascript functions bindings added (like i18n() methods) using the KDeclarative library. Game's KgThemeProviders are supplied to this class which in turn registers them with the underlying QML engine, and adds KgImageProviders corresponding to each KgThemeProvider.
> 
> 3. KgItem QML component:
> This is simple QML Image element wrapper for showing sprites on QML views using the KgImageProviders. We specify which one of the KgImageProviders we want to use and which sprite key we want to show, and it will be painted on the view.
> 
> The patch may not stay up-to-date, relevant code is in "viranch/qtquick" branch in libkdegames's git repo.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 67b8b40 
>   declarativeimports/CMakeLists.txt PRE-CREATION 
>   declarativeimports/corebindingsplugin.h PRE-CREATION 
>   declarativeimports/corebindingsplugin.cpp PRE-CREATION 
>   declarativeimports/qml/KgItem.qml PRE-CREATION 
>   declarativeimports/qml/qmldir PRE-CREATION 
>   includes/CMakeLists.txt 8756a50 
>   includes/KgDeclarativeView PRE-CREATION 
>   kgdeclarativeview.h PRE-CREATION 
>   kgdeclarativeview.cpp PRE-CREATION 
>   kgimageprovider.h PRE-CREATION 
>   kgimageprovider.cpp PRE-CREATION 
>   kgthemeprovider.h 6ca9b63 
>   kgthemeprovider.cpp e186106 
> 
> Diff: http://git.reviewboard.kde.org/r/109365/diff/
> 
> 
> Testing
> -------
> 
> I'm using KBreakout to test all of this. The relevant port can be found in "qtquick/imageprovider" branch in KBreakout's git repo.
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130314/92862d18/attachment-0001.html>