[Kde-games-devel] Review Request 108460: On selecting new game don't abort existing game without confirmation

[Michael Reeves]

On Tuesday, March 12, 2013 6:45:44 PM Albert Astals Cid wrote:

There's various reasons:
 a) You asked it to be merged to master in the branch setting of this review
 b) Not being the maintainer of the game i decided to play it safe
 c) On Jan 26 we where ultra-frozen for 4.10.0 release and i did not feel like 
commiting something that didn't even have a bug from bugs.kde.org associated

If you want i guess we can put it in 4.10 now, but if you want your commits to 
end up there, target that branch in the future, not master :-)



Thanks for the calification . Would it be easier if I create a new review for 
the 4.10 branch? Also I could file a bug report there's one already on my 
distros bug tracker. The offending code is the same as currently in the 4.10 
branch. Thanks for your time.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130312/6ebc7569/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130312/6ebc7569/attachment.sig>