[Kde-games-devel] Review Request 108460: On selecting new game don't abort existing game without confirmation

[Albert Astals Cid]

> On Jan. 26, 2013, 5:08 p.m., Commit Hook wrote:
> > This review has been submitted with commit 0f4655733289d6703db20d89d9d49b7732d303fd by Albert Astals Cid on behalf of Michael Reeves to branch master.
> 
> Parker Coates wrote:
>     Thanks, Albert.
> 
> Michael Reeves wrote:
>     Any reason this was not pushed to the kde 10 branch? This is a fix for a broken feature not adding a new one.

There's various reasons:
 a) You asked it to be merged to master in the branch setting of this review
 b) Not being the maintainer of the game i decided to play it safe
 c) On Jan 26 we where ultra-frozen for 4.10.0 release and i did not feel like commiting something that didn't even have a bug from bugs.kde.org associated

If you want i guess we can put it in 4.10 now, but if you want your commits to end up there, target that branch in the future, not master :-)


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108460/#review26216
-----------------------------------------------------------


On March 12, 2013, 12:44 a.m., Michael Reeves wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108460/
> -----------------------------------------------------------
> 
> (Updated March 12, 2013, 12:44 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> When selecting new game with a game already running the old game automaticly aborts without warning.
> 
> 
> Diffs
> -----
> 
>   gameview.h f8ca719 
>   gameview.cc 3d0c97c 
>   mainwin.cc 366ab96 
> 
> Diff: http://git.reviewboard.kde.org/r/108460/diff/
> 
> 
> Testing
> -------
> 
> Verified that confirmation dialog comes up if a game is already running. Confirmed that cancling new game dialog or clicking no in confirmation dialog does not abort exiting game.
> 
> 
> Thanks,
> 
> Michael Reeves
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130312/5c865219/attachment.html>