[Kde-games-devel] Review Request 106772: add option to allow adjacent ships

[Roney Gomes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106772/#review28701
-----------------------------------------------------------


I apologize for not giving proper attention to your patch. I thought, due our last talk, you'd be still working on it and missed the e-mail notifying your last change. I know its good to receive a positive feedback and the right attention to our work.

Below I've pointed out some of the issues I've encountered in your patch, besides that, it's good to go.

Good job.


src/battlefield.h
<http://git.reviewboard.kde.org/r/106772/#comment21460>

    Is there any need for this comment?



src/kbattleshipui.rc
<http://git.reviewboard.kde.org/r/106772/#comment21462>

    The convention in KDE is to bump the "version" attribute of the GUI whenever you release a new ui.rc file.  Then it overrides any old ui.rc files that are lying around in the user's installation.
    
    When committing this patch you should also put the "GUI" hook keyword in your commit message, so the documentation team will be aware of user visible changes in the game.



src/networkentity.cpp
<http://git.reviewboard.kde.org/r/106772/#comment21461>

    I didn't understand this. What remains to be done?


- Roney Gomes


On Dec. 24, 2012, 11:41 a.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106772/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2012, 11:41 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Add the option to allow adjacent ships.
> When it is not checked, the ships can not be placed adjacent.
> 
> 
> This addresses bug 168659.
>     http://bugs.kde.org/show_bug.cgi?id=168659
> 
> 
> Diffs
> -----
> 
>   src/battlefield.h ae78166 
>   src/battlefield.cpp 32aa525 
>   src/controller.h bbae7a6 
>   src/controller.cpp 761eda4 
>   src/kbattleship.kcfg b615f30 
>   src/kbattleshipui.rc 7c51ac6 
>   src/mainwindow.cpp 82d9a14 
>   src/message.h 2757cf7 
>   src/message.cpp 59de527 
>   src/networkentity.h c82bfbd 
>   src/networkentity.cpp 5fff5b8 
>   src/playfield.h 56934dc 
>   src/playfield.cpp 61c0ac6 
>   src/protocol.cpp c5cbacc 
>   src/sea.h e76be24 
>   src/sea.cpp de8b697 
>   src/ship.h 5e35f1a 
>   src/ship.cpp 86858d9 
> 
> Diff: http://git.reviewboard.kde.org/r/106772/diff/
> 
> 
> Testing
> -------
> 
> tested locally.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130306/9c230a96/attachment.html>