<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106772/">http://git.reviewboard.kde.org/r/106772/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I apologize for not giving proper attention to your patch. I thought, due our last talk, you'd be still working on it and missed the e-mail notifying your last change. I know its good to receive a positive feedback and the right attention to our work.
Below I've pointed out some of the issues I've encountered in your patch, besides that, it's good to go.
Good job.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106772/diff/4/?file=100923#file100923line30" style="color: black; font-weight: bold; text-decoration: underline;">src/battlefield.h</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Q_OBJECT</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">BattleField</span><span class="p">(</span><span class="n">Sea</span><span class="o">*</span> <span class="n">parent</span><span class="p">,</span> <span class="k">const</span> <span class="n">Coord</span><span class="o">&</span> <span class="n">size</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">BattleField</span><span class="p">(</span><span class="n">Sea</span><span class="o">*</span> <span class="n">parent</span><span class="p">,</span> <span class="k">const</span> <span class="n">Coord</span><span class="o">&</span> <span class="n">size</span><span class="hl"> </span><span class="cm"><span class="hl">/*, const allow_adjacent_ships */</span></span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is there any need for this comment?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106772/diff/4/?file=100928#file100928line20" style="color: black; font-weight: bold; text-decoration: underline;">src/kbattleshipui.rc</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o"><</span><span class="n">Action</span> <span class="n">name</span><span class="o">=</span><span class="s">"options_adjacent"</span> <span class="o">/></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The convention in KDE is to bump the "version" attribute of the GUI whenever you release a new ui.rc file. Then it overrides any old ui.rc files that are lying around in the user's installation.
When committing this patch you should also put the "GUI" hook keyword in your commit message, so the documentation team will be aware of user visible changes in the game.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106772/diff/4/?file=100933#file100933line43" style="color: black; font-weight: bold; text-decoration: underline;">src/networkentity.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void NetworkEntity::start(bool ask)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_protocol</span><span class="o">-></span><span class="n">send</span><span class="p">(</span><span class="n">MessagePtr</span><span class="p">(</span><span class="k">new</span> <span class="n">GameOptionsMessage</span><span class="p">(</span><span class="n">QString</span><span class="p">(</span><span class="n">Settings</span><span class="o">::</span><span class="n">adjacentShips</span><span class="p">()</span> <span class="o">?</span> <span class="s">"true"</span> <span class="o">:</span> <span class="s">"false"</span><span class="p">),</span> <span class="cm">/* </span><span class="cs">TODO</span><span class="cm"> */</span><span class="s">"true"</span><span class="p">)));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I didn't understand this. What remains to be done?</pre>
</div>
<br />
<p>- Roney</p>
<br />
<p>On December 24th, 2012, 11:41 a.m. UTC, Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Dec. 24, 2012, 11:41 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add the option to allow adjacent ships.
When it is not checked, the ships can not be placed adjacent.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested locally.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=168659">168659</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/battlefield.h <span style="color: grey">(ae78166)</span></li>
<li>src/battlefield.cpp <span style="color: grey">(32aa525)</span></li>
<li>src/controller.h <span style="color: grey">(bbae7a6)</span></li>
<li>src/controller.cpp <span style="color: grey">(761eda4)</span></li>
<li>src/kbattleship.kcfg <span style="color: grey">(b615f30)</span></li>
<li>src/kbattleshipui.rc <span style="color: grey">(7c51ac6)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(82d9a14)</span></li>
<li>src/message.h <span style="color: grey">(2757cf7)</span></li>
<li>src/message.cpp <span style="color: grey">(59de527)</span></li>
<li>src/networkentity.h <span style="color: grey">(c82bfbd)</span></li>
<li>src/networkentity.cpp <span style="color: grey">(5fff5b8)</span></li>
<li>src/playfield.h <span style="color: grey">(56934dc)</span></li>
<li>src/playfield.cpp <span style="color: grey">(61c0ac6)</span></li>
<li>src/protocol.cpp <span style="color: grey">(c5cbacc)</span></li>
<li>src/sea.h <span style="color: grey">(e76be24)</span></li>
<li>src/sea.cpp <span style="color: grey">(de8b697)</span></li>
<li>src/ship.h <span style="color: grey">(5e35f1a)</span></li>
<li>src/ship.cpp <span style="color: grey">(86858d9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106772/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>