[Kde-games-devel] Review Request 108606: Add an option to change the row height

[Ian Simpson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108606/
-----------------------------------------------------------

(Updated Jan. 29, 2013, 9:25 p.m.)


Review request for KDE Games.


Changes
-------

Removed paint.

Added a connection in configwidget to keep the minimum row height in sync with the font size.

I set the default height to the same as the font's and then check in the kiriki constructor if a larger font has been set, which will be pointless after new settings are saved.

I looked for the right way to make a change like this and, having just read about updating KConfig files at KDE techbase, it seems the correct solution is a .upd file and script?


Description
-------

Adds a configuration option to set the row height of the tableview.

Would have liked to prevent the height being set smaller than the font size. I tried to figure out how to get hold of the rowHeight spinbox in order to set its minimum value to that of the font size when it was changed, but couldn't. Anyone give me a hint? :-)

Other than that it seems to work OK.


This addresses bug 309428.
    http://bugs.kde.org/show_bug.cgi?id=309428


Diffs (updated)
-----

  src/itemdelegate.h PRE-CREATION 
  src/configwidget.cpp 30851ae 
  src/configwidget.h e35be7a 
  src/configPage.ui 5382a33 
  src/CMakeLists.txt 1a0f3a8 
  src/itemdelegate.cpp PRE-CREATION 
  src/kiriki.h 357b771 
  src/kiriki.cpp 4571d8f 
  src/kiriki.kcfg 785991a 

Diff: http://git.reviewboard.kde.org/r/108606/diff/


Testing
-------

Simply played a few games, changing the font size and row height.


Thanks,

Ian Simpson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130129/9a790862/attachment.html>