<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108606/">http://git.reviewboard.kde.org/r/108606/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Ian Simpson.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2013, 9:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed paint.
Added a connection in configwidget to keep the minimum row height in sync with the font size.
I set the default height to the same as the font's and then check in the kiriki constructor if a larger font has been set, which will be pointless after new settings are saved.
I looked for the right way to make a change like this and, having just read about updating KConfig files at KDE techbase, it seems the correct solution is a .upd file and script?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds a configuration option to set the row height of the tableview.
Would have liked to prevent the height being set smaller than the font size. I tried to figure out how to get hold of the rowHeight spinbox in order to set its minimum value to that of the font size when it was changed, but couldn't. Anyone give me a hint? :-)
Other than that it seems to work OK.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Simply played a few games, changing the font size and row height.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=309428">309428</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/itemdelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/configwidget.cpp <span style="color: grey">(30851ae)</span></li>
<li>src/configwidget.h <span style="color: grey">(e35be7a)</span></li>
<li>src/configPage.ui <span style="color: grey">(5382a33)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(1a0f3a8)</span></li>
<li>src/itemdelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kiriki.h <span style="color: grey">(357b771)</span></li>
<li>src/kiriki.cpp <span style="color: grey">(4571d8f)</span></li>
<li>src/kiriki.kcfg <span style="color: grey">(785991a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108606/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>