[Kde-games-devel] Review Request 108606: Add an option to change the row height

[Ian Simpson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108606/
-----------------------------------------------------------

(Updated Jan. 27, 2013, 11:49 a.m.)


Review request for KDE Games.


Changes
-------

Remove m_boldRows, remove stupid arbitrary values, fix spacing, remove unrelated change.

I left the paint method in because without it the cells are drawn with a vertical gradient and I wanted to have the same style as before. Should I just remove it?


Description
-------

Adds a configuration option to set the row height of the tableview.

Would have liked to prevent the height being set smaller than the font size. I tried to figure out how to get hold of the rowHeight spinbox in order to set its minimum value to that of the font size when it was changed, but couldn't. Anyone give me a hint? :-)

Other than that it seems to work OK.


This addresses bug 309428.
    http://bugs.kde.org/show_bug.cgi?id=309428


Diffs (updated)
-----

  src/CMakeLists.txt 1a0f3a8 
  src/configPage.ui 5382a33 
  src/itemdelegate.h PRE-CREATION 
  src/itemdelegate.cpp PRE-CREATION 
  src/kiriki.h 357b771 
  src/kiriki.cpp 4571d8f 
  src/kiriki.kcfg 785991a 

Diff: http://git.reviewboard.kde.org/r/108606/diff/


Testing
-------

Simply played a few games, changing the font size and row height.


Thanks,

Ian Simpson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130127/7d7a4d6b/attachment.html>