[Kde-games-devel] Review Request 108606: Add an option to change the row height

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108606/#review26222
-----------------------------------------------------------



src/itemdelegate.cpp
<http://git.reviewboard.kde.org/r/108606/#comment19938>

    You should not need m_boldRows, the current code bolds the fonts already no? So that info is available somewhere for you to use



src/itemdelegate.cpp
<http://git.reviewboard.kde.org/r/108606/#comment19937>

    Why the -8 ?



src/itemdelegate.cpp
<http://git.reviewboard.kde.org/r/108606/#comment19936>

    Why the * 2?



src/itemdelegate.cpp
<http://git.reviewboard.kde.org/r/108606/#comment19939>

    Why did you need to overload the paint method? Shouldn't the sizeHint be enough?



src/kiriki.kcfg
<http://git.reviewboard.kde.org/r/108606/#comment19934>

    Can you try to keep the file spacing consistent?



src/scores.cpp
<http://git.reviewboard.kde.org/r/108606/#comment19935>

    Seems an unrelated change


- Albert Astals Cid


On Jan. 26, 2013, 7:39 p.m., Ian Simpson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108606/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2013, 7:39 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Adds a configuration option to set the row height of the tableview.
> 
> Would have liked to prevent the height being set smaller than the font size. I tried to figure out how to get hold of the rowHeight spinbox in order to set its minimum value to that of the font size when it was changed, but couldn't. Anyone give me a hint? :-)
> 
> Other than that it seems to work OK.
> 
> 
> This addresses bug 309428.
>     http://bugs.kde.org/show_bug.cgi?id=309428
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 1a0f3a8 
>   src/configPage.ui 5382a33 
>   src/itemdelegate.h PRE-CREATION 
>   src/itemdelegate.cpp PRE-CREATION 
>   src/kiriki.h 357b771 
>   src/kiriki.cpp 4571d8f 
>   src/kiriki.kcfg 785991a 
>   src/scores.cpp 04da2e6 
> 
> Diff: http://git.reviewboard.kde.org/r/108606/diff/
> 
> 
> Testing
> -------
> 
> Simply played a few games, changing the font size and row height.
> 
> 
> Thanks,
> 
> Ian Simpson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130126/223d1a7e/attachment.html>