[Kde-games-devel] Review Request: List scores according to difficulty

[Albert Astals Cid]

> On Jan. 8, 2013, 9:42 p.m., Albert Astals Cid wrote:
> > Hi Jack, the code looks good, i will need your full name and email address so we can give you proper credit when commiting the fix.
> 
> jack daniel wrote:
>     Ian Simpson, ian.kdedev at yahoo.com
>     
>     I'll create a new account with my real name.

Yes please, real names always help :-)


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108269/#review25010
-----------------------------------------------------------


On Jan. 8, 2013, 5:26 p.m., jack daniel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108269/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2013, 5:26 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Try to add scores to the correct difficulty level.
> 
> Someone posted a patch at bugs.kde.org, but that seems to add the score to the next level higher than that played.
> 
> KExtHighscore::setGameType() seems to add scores from level 0 up.
> 
> 
> This addresses bug 305661.
>     http://bugs.kde.org/show_bug.cgi?id=305661
> 
> 
> Diffs
> -----
> 
>   mainwindow.cpp 47d7826 
> 
> Diff: http://git.reviewboard.kde.org/r/108269/diff/
> 
> 
> Testing
> -------
> 
> Lost a few games at different levels. Looks OK.
> 
> 
> Thanks,
> 
> jack daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130109/d5c310c0/attachment.html>