[Kde-games-devel] Review Request 114639: [knavalbattle] avoid semi-transparents first shots

[Albert Astals Cid]

> On Dec. 28, 2013, 6:53 p.m., Albert Astals Cid wrote:
> > src/button.cpp, line 228
> > <https://git.reviewboard.kde.org/r/114639/diff/1/?file=227050#file227050line228>
> >
> >     Instead of this just remove the m_current variable, it isn't used at all :D
> 
> Jaime Torres Amate wrote:
>     I've just realized that this patch by itself does not avoid the semitransparent shots.
>     It is something from the patch to show the not sunk ships the one that does it (I've always thought it was this patch, so I do not know what does fix this problem).
>     
>     Applied to 4.11 does not avoid the problem. Applied to 4.12 does not avoid the problem.
>     Applied the "show sunk ships" to 4.12 without this patch the problem is gone. Applied both, the problem is also gone.
>     
>     Therefore if I submit this patch, it it just for code correctness.

I'd commit it anyway, makes sense to init the variables (for m_current just kill it, no need to have something that is unused)


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114639/#review46313
-----------------------------------------------------------


On Dec. 24, 2013, 9:18 a.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114639/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2013, 9:18 a.m.)
> 
> 
> Review request for KDE Games and Roney Gomes.
> 
> 
> Bugs: 320883
>     http://bugs.kde.org/show_bug.cgi?id=320883
> 
> 
> Repository: knavalbattle
> 
> 
> Description
> -------
> 
> Before, after a match against the AI, and a Restart, the first shot was always semi-transparent (or gray in the sea).
> Initialize 3 variables, and the shots are always the same (white in the sea).
> 
> 
> Diffs
> -----
> 
>   src/animation.cpp 951b5a6 
>   src/button.cpp 3ff23a5 
> 
> Diff: https://git.reviewboard.kde.org/r/114639/diff/
> 
> 
> Testing
> -------
> 
> It has been tested more than a hundred times (while testing the several ships and shunk ships patches)
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131229/8d2d4c82/attachment.html>