[Kde-games-devel] Review Request 111049: KNetWalk QML port

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111049/#review38034
-----------------------------------------------------------


Looks nice, and the diffstat is nice too
 18 files changed, 631 insertions(+), 915 deletions(-)

Having a look at the code i just have one question, all those invokeMethods, would it maybe be nicer if you just emit a signal from the c++ side that is connected in the qml side?

- Albert Astals Cid


On Aug. 17, 2013, 7:57 a.m., Ashwin Rajeev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111049/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2013, 7:57 a.m.)
> 
> 
> Review request for KDE Games, Albert Astals Cid and Viranch Mehta.
> 
> 
> Description
> -------
> 
> QML port
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt d017d1a 
>   src/abstractgrid.h ddd9911 
>   src/cell.h 9254935 
>   src/cell.cpp 7555e1d 
>   src/fielditem.h 91e1a33 
>   src/fielditem.cpp a04ad6e 
>   src/main.cpp ce3d7a6 
>   src/mainwindow.h 2c047b6 
>   src/mainwindow.cpp d7d6fbd 
>   src/qml/Cable.qml PRE-CREATION 
>   src/qml/CanvasItem.qml PRE-CREATION 
>   src/qml/Cell.qml PRE-CREATION 
>   src/qml/logic.js PRE-CREATION 
>   src/qml/main.qml PRE-CREATION 
>   src/scene.h 7753303 
>   src/scene.cpp 38c276f 
>   src/view.h 9de36b8 
>   src/view.cpp 95fe9b4 
> 
> Diff: http://git.reviewboard.kde.org/r/111049/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashwin Rajeev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130817/457e39b5/attachment.html>