<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111049/">http://git.reviewboard.kde.org/r/111049/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks nice, and the diffstat is nice too
18 files changed, 631 insertions(+), 915 deletions(-)
Having a look at the code i just have one question, all those invokeMethods, would it maybe be nicer if you just emit a signal from the c++ side that is connected in the qml side?</pre>
<br />
<p>- Albert</p>
<br />
<p>On August 17th, 2013, 7:57 a.m. UTC, Ashwin Rajeev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games, Albert Astals Cid and Viranch Mehta.</div>
<div>By Ashwin Rajeev.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2013, 7:57 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QML port</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(d017d1a)</span></li>
<li>src/abstractgrid.h <span style="color: grey">(ddd9911)</span></li>
<li>src/cell.h <span style="color: grey">(9254935)</span></li>
<li>src/cell.cpp <span style="color: grey">(7555e1d)</span></li>
<li>src/fielditem.h <span style="color: grey">(91e1a33)</span></li>
<li>src/fielditem.cpp <span style="color: grey">(a04ad6e)</span></li>
<li>src/main.cpp <span style="color: grey">(ce3d7a6)</span></li>
<li>src/mainwindow.h <span style="color: grey">(2c047b6)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(d7d6fbd)</span></li>
<li>src/qml/Cable.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qml/CanvasItem.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qml/Cell.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qml/logic.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qml/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scene.h <span style="color: grey">(7753303)</span></li>
<li>src/scene.cpp <span style="color: grey">(38c276f)</span></li>
<li>src/view.h <span style="color: grey">(9de36b8)</span></li>
<li>src/view.cpp <span style="color: grey">(95fe9b4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111049/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>