[Kde-games-devel] Review Request 110126: Changed two QTimer objects to QTimeLine objects, so that pause and resume functionality can be used to pause the Timers when the game is paused.

Viranch Mehta viranch.mehta at gmail.com
Thu Apr 25 21:57:42 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110126/#review31599
-----------------------------------------------------------



game.cpp
<http://git.reviewboard.kde.org/r/110126/#comment23525>

    indentation is not uniform to rest of the code, you're using spaces to indent while rest of the file has tab characters to indent.



game.cpp
<http://git.reviewboard.kde.org/r/110126/#comment23526>

    same space vs tabs indent



game.cpp
<http://git.reviewboard.kde.org/r/110126/#comment23527>

    should go one indent to the right



game.cpp
<http://git.reviewboard.kde.org/r/110126/#comment23528>

    one indent to the right


- Viranch Mehta


On April 25, 2013, 9:13 p.m., Dishant  Patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110126/
> -----------------------------------------------------------
> 
> (Updated April 25, 2013, 9:13 p.m.)
> 
> 
> Review request for KDE Games and Viranch Mehta.
> 
> 
> Description
> -------
> 
> With respect to the bug, https://bugs.kde.org/show_bug.cgi?id=190372, i have implemented the m_bonusTimer and m_preyTimer timers to pause when the game state is Paused, and the timers resume when the game state resumes.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=190372.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=190372
> 
> 
> Diffs
> -----
> 
>   game.h be82b55 
>   game.cpp ddbc106 
> 
> Diff: http://git.reviewboard.kde.org/r/110126/diff/
> 
> 
> Testing
> -------
> 
> Yes,it works fine in my system.
> 
> 
> Thanks,
> 
> Dishant  Patel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130425/82cdf22b/attachment-0001.html>


More information about the kde-games-devel mailing list