[Kde-games-devel] Review Request 110126: Changed two QTimer objects to QTimeLine objects, so that pause and resume functionality can be used to pause the Timers when the game is paused.

Dishant Patel dishantpatel.rk at gmail.com
Thu Apr 25 16:40:57 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110126/
-----------------------------------------------------------

(Updated April 25, 2013, 4:40 p.m.)


Review request for KDE Games and Viranch Mehta.


Changes
-------

Changes includes the Pausing and Resuming code is transferred to pause() and start() function with  proper indentation, also, when bonustimer and preytimer is started, it is checked if they are already running or not! if yes, they are stopped first and then, they are started.


Description
-------

With respect to the bug, https://bugs.kde.org/show_bug.cgi?id=190372, i have implemented the m_bonusTimer and m_preyTimer timers to pause when the game state is Paused, and the timers resume when the game state resumes.


This addresses bug https://bugs.kde.org/show_bug.cgi?id=190372.
    http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=190372


Diffs (updated)
-----

  game.cpp ddbc106 

Diff: http://git.reviewboard.kde.org/r/110126/diff/


Testing
-------

Yes,it works fine in my system.


Thanks,

Dishant  Patel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130425/d0b27cb8/attachment.html>


More information about the kde-games-devel mailing list