[Kde-games-devel] Review Request 110132: QML image provider for KIcon images

[Albert Astals Cid]

> On April 22, 2013, 9:36 p.m., Albert Astals Cid wrote:
> > What's the problem with the existing one provided by kdeclarative?
> 
> Viranch Mehta wrote:
>     its part of plasma components and using it would add a dependency to kde-runtime.

kde-runtime is a dependency of all the kde apps.

Besides it's not in kde-runtime is in kdelibs and we are already using the kdeclarative library ;-)


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110132/#review31434
-----------------------------------------------------------


On April 22, 2013, 9:11 p.m., Viranch Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110132/
> -----------------------------------------------------------
> 
> (Updated April 22, 2013, 9:11 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> This patch introduces a new image provider for libkdegames that enables showing KIcon's inside QML. Additionally, ships a KIcon QML component as a wrapper component that takes in the KIcon's name and uses the image provider to show the pixmap.
> 
> The purpose of the image provider is for the QML component that I'm working on for KGamePopupItem. Many games use this and should be a readily available component. This component shows a KIcon as its icon alongside the text, hence the patch and the new image provider.
> 
> 
> Diffs
> -----
> 
>   declarativeimports/CMakeLists.txt c5b88d9 
>   declarativeimports/corebindingsplugin.h bc3fa32 
>   declarativeimports/corebindingsplugin.cpp 3fef508 
>   declarativeimports/kiconprovider.cpp PRE-CREATION 
>   declarativeimports/kiconprovider_p.h PRE-CREATION 
>   declarativeimports/qml/KIcon.qml PRE-CREATION 
>   declarativeimports/qml/qmldir 79aae32 
> 
> Diff: http://git.reviewboard.kde.org/r/110132/diff/
> 
> 
> Testing
> -------
> 
> Tested with a simple QML file: http://sprunge.us/Ggje and "qmlviewer -I $KDEDIR/lib/kde4/imports test.qml". shows the correct icon image.
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130423/a83936be/attachment.html>