[Kde-games-devel] Review Request 110132: QML image provider for KIcon images
Viranch Mehta
viranch.mehta at gmail.com
Tue Apr 23 08:51:34 UTC 2013
> On April 22, 2013, 9:36 p.m., Albert Astals Cid wrote:
> > What's the problem with the existing one provided by kdeclarative?
its part of plasma components and using it would add a dependency to kde-runtime.
- Viranch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110132/#review31434
-----------------------------------------------------------
On April 22, 2013, 9:11 p.m., Viranch Mehta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110132/
> -----------------------------------------------------------
>
> (Updated April 22, 2013, 9:11 p.m.)
>
>
> Review request for KDE Games.
>
>
> Description
> -------
>
> This patch introduces a new image provider for libkdegames that enables showing KIcon's inside QML. Additionally, ships a KIcon QML component as a wrapper component that takes in the KIcon's name and uses the image provider to show the pixmap.
>
> The purpose of the image provider is for the QML component that I'm working on for KGamePopupItem. Many games use this and should be a readily available component. This component shows a KIcon as its icon alongside the text, hence the patch and the new image provider.
>
>
> Diffs
> -----
>
> declarativeimports/CMakeLists.txt c5b88d9
> declarativeimports/corebindingsplugin.h bc3fa32
> declarativeimports/corebindingsplugin.cpp 3fef508
> declarativeimports/kiconprovider.cpp PRE-CREATION
> declarativeimports/kiconprovider_p.h PRE-CREATION
> declarativeimports/qml/KIcon.qml PRE-CREATION
> declarativeimports/qml/qmldir 79aae32
>
> Diff: http://git.reviewboard.kde.org/r/110132/diff/
>
>
> Testing
> -------
>
> Tested with a simple QML file: http://sprunge.us/Ggje and "qmlviewer -I $KDEDIR/lib/kde4/imports test.qml". shows the correct icon image.
>
>
> Thanks,
>
> Viranch Mehta
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130423/695e9b61/attachment.html>
More information about the kde-games-devel
mailing list