[Kde-games-devel] Review Request 109827: Add custom game level

[Ashwin Rajeev]

> On April 2, 2013, 7:53 p.m., Jakob Gruber wrote:
> > I noticed you changed the coding style in CMakeLists.txt and incremented the version; was that on purpose?
> 
> Ashwin Rajeev wrote:
>     Coding style in that document was different in many places, so i just tried to make it uniform.
>     I also incremented the version on purpose.
> 
> Jakob Gruber wrote:
>     Let me rephrase that question; did you discuss the version change with anyone? It seems a little strange to increment it because of one added feature.

I didn't discuss it with any one. I thought such discussions are done here.
KNetWalk was changed to version 3.0.0 on 2008-06-24. 
Porting to KGameRenderer, KgTheme, KgDifficulty was done after that and recently i ported KNetWalk from KNofity to KgSound.


- Ashwin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109827/#review30289
-----------------------------------------------------------


On April 4, 2013, 9:35 p.m., Ashwin Rajeev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109827/
> -----------------------------------------------------------
> 
> (Updated April 4, 2013, 9:35 p.m.)
> 
> 
> Review request for KDE Games and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> Custom game level where user can select size ( 3 - 11 ) and whether wrapping is needed.
> 
> Feature: 221727
> 
> 
> This addresses bug 221727.
>     http://bugs.kde.org/show_bug.cgi?id=221727
> 
> 
> Diffs
> -----
> 
>   doc/index.docbook b264e43 
>   src/CMakeLists.txt fbee0f6 
>   src/customgame.ui PRE-CREATION 
>   src/knetwalk.kcfg 19e6f97 
>   src/main.cpp 0113bcf 
>   src/mainwindow.h f5609e4 
>   src/mainwindow.cpp 7c1e47f 
> 
> Diff: http://git.reviewboard.kde.org/r/109827/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashwin Rajeev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130405/24350a0e/attachment-0001.html>