<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109827/">http://git.reviewboard.kde.org/r/109827/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 2nd, 2013, 7:53 p.m. UTC, <b>Jakob Gruber</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I noticed you changed the coding style in CMakeLists.txt and incremented the version; was that on purpose?</pre>
</blockquote>
<p>On April 3rd, 2013, 7:41 a.m. UTC, <b>Ashwin Rajeev</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Coding style in that document was different in many places, so i just tried to make it uniform.
I also incremented the version on purpose.</pre>
</blockquote>
<p>On April 4th, 2013, 9:43 p.m. UTC, <b>Jakob Gruber</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Let me rephrase that question; did you discuss the version change with anyone? It seems a little strange to increment it because of one added feature.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I didn't discuss it with any one. I thought such discussions are done here.
KNetWalk was changed to version 3.0.0 on 2008-06-24.
Porting to KGameRenderer, KgTheme, KgDifficulty was done after that and recently i ported KNetWalk from KNofity to KgSound.
</pre>
<br />
<p>- Ashwin</p>
<br />
<p>On April 4th, 2013, 9:35 p.m. UTC, Ashwin Rajeev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games and Albert Astals Cid.</div>
<div>By Ashwin Rajeev.</div>
<p style="color: grey;"><i>Updated April 4, 2013, 9:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Custom game level where user can select size ( 3 - 11 ) and whether wrapping is needed.
Feature: 221727</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=221727">221727</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/index.docbook <span style="color: grey">(b264e43)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(fbee0f6)</span></li>
<li>src/customgame.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/knetwalk.kcfg <span style="color: grey">(19e6f97)</span></li>
<li>src/main.cpp <span style="color: grey">(0113bcf)</span></li>
<li>src/mainwindow.h <span style="color: grey">(f5609e4)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(7c1e47f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109827/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>