[Kde-games-devel] Review Request 109827: Add custom game level

[Albert Astals Cid]

> On April 3, 2013, 11:19 p.m., Albert Astals Cid wrote:
> > src/mainwindow.cpp, line 185
> > <http://git.reviewboard.kde.org/r/109827/diff/3/?file=130142#file130142line185>
> >
> >     This creates a dialog every time we click on the settings but the dialog is not freed until the mainwindow goes again so if we click 1000 times in configure settings we have 1000 dialogs resident in memory, you may want to either reuse the same dialog or make sure the dialog gets deleted on close (by using exec() + delete or by setting the deleteOnClose flag on the dialog)
> 
> Ashwin Rajeev wrote:
>     if(KConfigDialog::showDialog("settings")) return; 
>     Does this line check whether there is already a instance created?
> 
> Albert Astals Cid wrote:
>     Put a kDebug in there.
>     
>     The only thing that protects you is when you try to open a dialog when the dialog is already open.
>     
>     BTW You put the bug number in the branch field instead of in the bug field ;-)
> 
> Ashwin Rajeev wrote:
>     I have already used kDebug() and new dialog is only creating once.
>     The example here also uses same code : http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKConfigDialog.html

You're right, no need to change anything in there


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109827/#review30345
-----------------------------------------------------------


On April 4, 2013, 7:52 p.m., Ashwin Rajeev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109827/
> -----------------------------------------------------------
> 
> (Updated April 4, 2013, 7:52 p.m.)
> 
> 
> Review request for KDE Games and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> Custom game level where user can select size ( 3 - 11 ) and whether wrapping is needed.
> 
> Feature: 221727
> 
> 
> This addresses bug 221727.
>     http://bugs.kde.org/show_bug.cgi?id=221727
> 
> 
> Diffs
> -----
> 
>   doc/index.docbook b264e43 
>   src/CMakeLists.txt fbee0f6 
>   src/customgame.ui PRE-CREATION 
>   src/knetwalk.kcfg 19e6f97 
>   src/main.cpp 0113bcf 
>   src/mainwindow.h f5609e4 
>   src/mainwindow.cpp 7c1e47f 
> 
> Diff: http://git.reviewboard.kde.org/r/109827/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashwin Rajeev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130404/a77ed12d/attachment-0001.html>