<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109827/">http://git.reviewboard.kde.org/r/109827/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 3rd, 2013, 11:19 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109827/diff/3/?file=130142#file130142line185" style="color: black; font-weight: bold; text-decoration: underline;">src/mainwindow.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">184</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KConfigDialog</span> <span class="o">*</span><span class="n">dialog</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KConfigDialog</span><span class="p">(</span><span class="k">this</span><span class="p">,</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="s">"settings"</span><span class="p">),</span> <span class="n">Settings</span><span class="o">::</span><span class="n">self</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This creates a dialog every time we click on the settings but the dialog is not freed until the mainwindow goes again so if we click 1000 times in configure settings we have 1000 dialogs resident in memory, you may want to either reuse the same dialog or make sure the dialog gets deleted on close (by using exec() + delete or by setting the deleteOnClose flag on the dialog)</pre>
</blockquote>
<p>On April 4th, 2013, 8:24 a.m. UTC, <b>Ashwin Rajeev</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">if(KConfigDialog::showDialog("settings")) return;
Does this line check whether there is already a instance created?</pre>
</blockquote>
<p>On April 4th, 2013, 6:21 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Put a kDebug in there.
The only thing that protects you is when you try to open a dialog when the dialog is already open.
BTW You put the bug number in the branch field instead of in the bug field ;-)</pre>
</blockquote>
<p>On April 4th, 2013, 8:05 p.m. UTC, <b>Ashwin Rajeev</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have already used kDebug() and new dialog is only creating once.
The example here also uses same code : http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKConfigDialog.html</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You're right, no need to change anything in there</pre>
<br />
<p>- Albert</p>
<br />
<p>On April 4th, 2013, 7:52 p.m. UTC, Ashwin Rajeev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games and Albert Astals Cid.</div>
<div>By Ashwin Rajeev.</div>
<p style="color: grey;"><i>Updated April 4, 2013, 7:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Custom game level where user can select size ( 3 - 11 ) and whether wrapping is needed.
Feature: 221727</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=221727">221727</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/index.docbook <span style="color: grey">(b264e43)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(fbee0f6)</span></li>
<li>src/customgame.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/knetwalk.kcfg <span style="color: grey">(19e6f97)</span></li>
<li>src/main.cpp <span style="color: grey">(0113bcf)</span></li>
<li>src/mainwindow.h <span style="color: grey">(f5609e4)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(7c1e47f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109827/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>