[Kde-games-devel] kmahjongg qgraphic branch

[Albert Astals Cid]

El Dimecres, 3 d'abril de 2013, a les 22:40:32, Ian Simpson va escriure:
> Hello all,
> 
> So I've done some work on the branch and think it would be good to get some
> feedback.
> 
> It seems stable, and I've tried to implement the missing features and
> settings. I'm pretty happy with the result, if not so sure about the coding
> :-)
> 
> I'm not sure about having to disconnect from the selectionChanged() signal
> but tried various things and that was the only one that stopped the
> crashing and/or warning messages about items being in a different, or no
> scene. Don't know if I should have used scene()->blockSignals() instead, or
> done it a different way entirely.
> 
> Anyway, if anyone wants to take a look it would be great.

I will eventually have a look, but I'm swamped on a lots of TODOs at the 
moment (I did go on holiday on easter and seems the rest of the world didn't 
and did stuff I need to review :D) so it may take a while. So obviously it'd 
be great if someone else can have a look :-)

Just to clarify, are you suggesting this to replace master already or is just 
a "middle trip check"?

Cheers,
  Albert

> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel