[Kde-games-devel] Review Request: Fix crash with grayscale images

[Parker Coates]

> On Oct. 1, 2012, 11:11 p.m., Parker Coates wrote:
> > Seems like the sane thing to do. How does this handle interact with transparent images? See bugs.kde.org/show_bug.cgi?id=211857
> 
> Christoph Feck wrote:
>     I tried with and without this patch, and in both cases Palapeli simply renders garbage where there should be transparency. I do not understand the "fix" for bug 211857, what is the alpha value 42 supposed to do?

No idea. If the functionality seems the broken both before and after, then you probably don't have to worry about.


- Parker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106678/#review19719
-----------------------------------------------------------


On Oct. 1, 2012, 6:31 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106678/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2012, 6:31 p.m.)
> 
> 
> Review request for KDE Games and Stefan Majewsky.
> 
> 
> Description
> -------
> 
> Convert the image to RGB to avoid a crash with grayscale (or other indexed) images.
> 
> 
> This addresses bug 236625.
>     http://bugs.kde.org/show_bug.cgi?id=236625
> 
> 
> Diffs
> -----
> 
>   src/creator/puzzlecreator.cpp 3c8df18 
> 
> Diff: http://git.reviewboard.kde.org/r/106678/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121004/812ca9cd/attachment.html>