[Kde-games-devel] Review Request: Solution for Bug 308889: "Can not change the difficulty level after starting the first game."

Albert Astals Cid tsdgeos at terra.es
Fri Nov 30 23:25:43 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107084/#review22848
-----------------------------------------------------------

Ship it!


Seems to work fine, feel free to commit it after fixng the comment below


mainwindow.cpp
<http://git.reviewboard.kde.org/r/107084/#comment17430>

    You probably don't need this one, right?


- Albert Astals Cid


On Nov. 24, 2012, 6:41 p.m., Roney Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107084/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2012, 6:41 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Solves the bug, allowing the player to change the difficulty level at any time.
> 
> 
> This addresses bug 308889.
>     http://bugs.kde.org/show_bug.cgi?id=308889
> 
> 
> Diffs
> -----
> 
>   gamewidget.h ade3d64 
>   gamewidget.cpp 3e7b12e 
>   mainwindow.cpp 5ab7e8c 
> 
> Diff: http://git.reviewboard.kde.org/r/107084/diff/
> 
> 
> Testing
> -------
> 
> The difficulty was changed in different levels of KBounce. It was also verified whether a restored game applies the difficulty set in a previous execution of the game.
> 
> 
> Thanks,
> 
> Roney Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121130/25e8a944/attachment.html>


More information about the kde-games-devel mailing list