[Kde-games-devel] Review Request: Bug 308380 - Canceling change of difficulty level restarts the current game.

[Roney Gomes]

> On Nov. 1, 2012, 4:01 p.m., Albert Astals Cid wrote:
> > Maybe hook ourselves to currentLevelChanged instead of selectedLevelChanged ?

Yes, that's exactly what I should have done. Thank you.


- Roney


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107053/#review21317
-----------------------------------------------------------


On Nov. 17, 2012, 5:08 p.m., Roney Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107053/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2012, 5:08 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> As described in the bug tracker, the game restarts even if the player decides to cancel the current selection. In the attached patch, the game verifies whether the player has decided to select a different level or not.
> 
> 
> This addresses bug 308380.
>     http://bugs.kde.org/show_bug.cgi?id=308380
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.cpp a7cceeb 
> 
> Diff: http://git.reviewboard.kde.org/r/107053/diff/
> 
> 
> Testing
> -------
> 
> Changed the difficulty level and then canceled the current selection.
> Changed the difficulty level and then accepted the current selection.
> 
> 
> Thanks,
> 
> Roney Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121117/8269bc83/attachment.html>