[Kde-games-devel] Review Request: Bug 308380 - Canceling change of difficulty level restarts the current game.

[Albert Astals Cid]

> On Nov. 1, 2012, 3:56 p.m., Albert Astals Cid wrote:
> > Errr, are you sure that accepting the game difficulty change works? I don't see the game restarting, besides you removed a function header and it does not even compile

Ah, had not seen there was a review for libkdegames that probably makes this work, still don't think the libkdegames thing is good and most probably just going to currentLevelChanged is what we need


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107053/#review21315
-----------------------------------------------------------


On Oct. 26, 2012, 12:58 p.m., Roney Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107053/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2012, 12:58 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> As described in the bug tracker, the game restarts even if the player decides to cancel the current selection. In the attached patch, the game verifies whether the player has decided to select a different level or not.
> 
> 
> This addresses bug 308380.
>     http://bugs.kde.org/show_bug.cgi?id=308380
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.cpp a7cceeb 
>   src/playfield.h 56934dc 
>   src/playfield.cpp 61c0ac6 
> 
> Diff: http://git.reviewboard.kde.org/r/107053/diff/
> 
> 
> Testing
> -------
> 
> Changed the difficulty level and then canceled the current selection.
> Changed the difficulty level and then accepted the current selection.
> 
> 
> Thanks,
> 
> Roney Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121101/02786f5c/attachment-0001.html>