[Kde-games-devel] Review Request: KgThemeProvider crash in rediscoverThemes()

[Stefan Majewsky]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6957/#review10806
-----------------------------------------------------------

Ship it!


Looks plausible.

- Stefan Majewsky


On May 22, 2012, 4:49 p.m., Mathias Kraus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6957/
> -----------------------------------------------------------
> 
> (Updated May 22, 2012, 4:49 p.m.)
> 
> 
> Review request for KDE Games and Stefan Majewsky.
> 
> 
> Description
> -------
> 
> If rediscoverThemes from KgThemeProvider is called right after discoverThemes, it will crash.
> This fixes the issue.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/libkdegames/kgthemeprovider.cpp 1296127 
> 
> Diff: http://svn.reviewboard.kde.org/r/6957/diff/
> 
> 
> Testing
> -------
> 
> called rediscoverThemes after discoverThemes and no crash happens
> 
> 
> Thanks,
> 
> Mathias Kraus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120523/da38d484/attachment.html>