[Kde-games-devel] Review Request: Porting Kapman from Phonon to KgSound

[Roney Gomes]

> On March 22, 2012, 11:48 a.m., Frederik Schwarzer wrote:
> > /trunk/KDE/kdegames/kapman/game.cpp, lines 37-44
> > <http://svn.reviewboard.kde.org/r/6914/diff/1/?file=47721#file47721line37>
> >
> >     Would it not better to put these into the initializer list? This way they are intialised twice, iirc.

Can you point another place in the code where the sounds are also loaded? I couldn't see it.


- Roney


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6914/#review10728
-----------------------------------------------------------


On March 22, 2012, 3:43 p.m., Roney Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6914/
> -----------------------------------------------------------
> 
> (Updated March 22, 2012, 3:43 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> I've ported kapman to KgSound as requested in the mailing list. The files changed were game.cpp and game.h.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kapman/game.h 1286463 
>   /trunk/KDE/kdegames/kapman/game.cpp 1286463 
> 
> Diff: http://svn.reviewboard.kde.org/r/6914/diff/
> 
> 
> Testing
> -------
> 
> I've played and observed whether the sounds were been played in the proper situations.
> 
> 
> Thanks,
> 
> Roney Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120322/cf9c7791/attachment.html>