[Kde-games-devel] Review Request: Porting Kapman from Phonon to KgSound

[Frederik Schwarzer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6914/#review10728
-----------------------------------------------------------


The Ship it marker is ment to be used by the reviewers. ;)


/trunk/KDE/kdegames/kapman/game.cpp
<http://svn.reviewboard.kde.org/r/6914/#comment13277>

    Would it not better to put these into the initializer list? This way they are intialised twice, iirc.



/trunk/KDE/kdegames/kapman/game.cpp
<http://svn.reviewboard.kde.org/r/6914/#comment13278>

    Please avoid unrelated white space changes. There are several.



/trunk/KDE/kdegames/kapman/game.cpp
<http://svn.reviewboard.kde.org/r/6914/#comment13279>

    Is the indentation correct here?


- Frederik Schwarzer


On March 22, 2012, 11:33 a.m., Roney Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6914/
> -----------------------------------------------------------
> 
> (Updated March 22, 2012, 11:33 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> I've ported kapman to KgSound as requested in the mailing list. The files changed were game.cpp and game.h.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kapman/game.h 1286463 
>   /trunk/KDE/kdegames/kapman/game.cpp 1286463 
> 
> Diff: http://svn.reviewboard.kde.org/r/6914/diff/
> 
> 
> Testing
> -------
> 
> I've played and observed whether the sounds were been played in the proper situations.
> 
> 
> Thanks,
> 
> Roney Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120322/73f34e1c/attachment-0001.html>