[Kde-games-devel] Rule Writing

[Parker Coates]

On Fri, Mar 9, 2012 at 17:23, Wolfgang Rohdewald wrote:
> Am Donnerstag, 2. Februar 2012, 13:59:12 schrieb Wolfgang Rohdewald:
>> Am Donnerstag, 2. Februar 2012, 13:01:36 schrieb Frederik Schwarzer:
>> > For that to happen, those who think their rules are finished, should
>> > make the resulting repo available for download
>>
>> git clone git at git.kde.org:scratch/wrohdewald/kajongg
>
> git clone git at git.kde.org:scratch/wrohdewald/libkmahjongg
>
> now preparing kmahjongg
>
> please note that kapman shows commits for branching like
> "Branch for KDE 4.8" in r1269583. Those commits hold no changes.
>
> kajongg and libkmahjongg don't have such commits. I compared
> with okular, kdelibs and akonadi and they don't have such commits
> either.
>
> I also looked at granatier which has the same empty branching
> commits so I suppose other games have them too.
>
> Personally I think it looks better without. Look at it with gitk --all.
> And if the core repositories do without, I think we should do
> the same.
>
> Also, when using only git, such commits do not exist since
> branching creates no commit.

I was having the same issue last night. It looks even worse for
temporary work branches that just get merged back into master after a
commit or two.

I asked Nicolás about it last night. It turns out the version
svn-all-fast-export on dewey.kde.org is more than a year old and the
empty branching commit issue has since been fixed. Sysadmins were
looking at doing an upgrade, but apparently that wasn't going to be
trivial. Nicolás uploaded a patched version in /home/git/nalvarez/
which can be used in the meantime.

Parker