[Kde-games-devel] ksokoban

[Shlomi Fish]

Hi Łukasz ,

thanks for your KSokoban effort.

Here are my experiences working on your KSokoban code.

On Sun, 22 Jul 2012 10:48:17 +0200
Łukasz Kalamłacki <kalamlacki at gmail.com> wrote:

> Hello,
> 
> I am software developer and I have just rewritten ksokoban game from kde 
> 3 to kde 4 so that the game can be executed without qt3 or qt3support 
> libraries, The one thing have left, preparation of makefiles.
> Do you think that ksokoban could be included in kde-games 4 package again?
> Who decides about this?
> 

OK, after I hg cloned the repository locally, I noticed that some of the files
were executable. So I fixed it using chmod a-x. Then I tried an out-of-tree
build:

mkdir build
cd build
cmake ..
make

It didn't work due to a missing "include_directories()" in the CMake which I
fixed too. So I decided to push my changes to my fork of the repository in
sourceforge.net. I was able to, but the changes did not appear there yet. So I
created a fork of the repository on bitbucket.org where the changes already
appear:

https://bitbucket.org/shlomif/ksokoban

Then I wanted to file a ticket here:

https://sourceforge.net/p/ksokoban/tickets/

I could not find how and appending "/new" to the URL told me I did not have the
right permissions. This is frustrating.

In any case, please pull from my bitbucket.org repository.

Then I wanted to play a game, and continue from where I finished on KDE 3 . It
didn't work as KSokoban reset my level to the first one. Then after reading the
code I noticed this:

 #ifndef WIN32
 #define GETUID() getuid()
 #else
 #define GETUID() 1000
 #endif

As I changed to a new computer, my uid has changed so I had to do:

+#if 1
+#define GETUID() 501
+#else

It's in my pull request and should not be in the code, but still the UID
is not a reliable seed for the scarambling algorithm. (This is not your fault,
naturally).

So I'm now quite vexed. Why can't software just work? ;-)

Regards,

	Shlomi Fish

-- 
-----------------------------------------------------------------
Shlomi Fish       http://www.shlomifish.org/
List of Portability Libraries - http://shlom.in/port-libs

mplayer 0.9.999.2010.03.11-rc5-adc83b19e793491b1c6ea0fd8b46cd9f32e592fc is
now available for download.
    — Shlomi Fish and d3x.

Please reply to list if it's a mailing list post - http://shlom.in/reply .