[Kde-games-devel] Port of KMahjongg

[Christian Krippendorf]

Hey guys,

the port of kmahjongg is now done in many ways. Just few bugs are out 
there, but that should be solved quickly for me. My question now following:

Can please anyone review my code out of the design? This is my first 
port to QGraphics-Framework and i'm really not sure if i had done all 
design things right. Maybe some functionallity should be in another 
class etc. etc. Just code design things.

The branch is branches/work/krippendorf the mainly affected files are:

GameItem.h/cpp - QGraphicsItem
GameView.h/cpp - QGraphicsView
GameScene.h/cpp - QGraphicsScene

Cause before i finished, i would have a short feedback. Surely cause of 
code style and some bugs i will start a code review on the review board 
later. This should just be a short and simple code design question.

I hope i filled up the right classes with the right functionality :-).

Thx in advance. Greedings.

-- 
Mit freundlichen Grüßen / Best Regards

Christian Krippendorf