[Kde-games-devel] Review Request: Provision of viewing and adding dates for high scores in Kiriki

[Arjun Basu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6905/
-----------------------------------------------------------

(Updated Feb. 29, 2012, 11:54 a.m.)


Review request for KDE Games.


Changes
-------

I tried the enums available for the QDate::toString() method and found the Qt::DefaultLocaleShortDate to be the most compact. The Qt::DefaultLocaleLongDate was taking up too much space and disfiguring the dialog. The compact notation is pretty good I think.


Description
-------

In Kiriki, now there is an extra Date Field in the High Scores Dialog. Also the date is recorded whenever a new high score is generated.
. This is in response to this bug report https://bugs.kde.org/show_bug.cgi?id=236656


Diffs (updated)
-----

  /trunk/KDE/kdegames/kiriki/src/kiriki.cpp 1282152 

Diff: http://svn.reviewboard.kde.org/r/6905/diff/


Testing
-------

Yes, I have tested the changes and it is working perfectly.


Screenshots
-----------

The High Scores Dialog
  http://svn.reviewboard.kde.org/r/6905/s/625/
New High Score
  http://svn.reviewboard.kde.org/r/6905/s/626/


Thanks,

Arjun Basu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120229/c72bb7f5/attachment.html>