[Kde-games-devel] Review Request: Provision of viewing and adding dates for high scores in Kiriki

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6905/#review10713
-----------------------------------------------------------



/trunk/KDE/kdegames/kiriki/src/kiriki.cpp
<http://svn.reviewboard.kde.org/r/6905/#comment13217>

    In these two lines please make the variable const and also do "foo = var" instead of "foo=var".



/trunk/KDE/kdegames/kiriki/src/kiriki.cpp
<http://svn.reviewboard.kde.org/r/6905/#comment13218>

    I was wondering if you played with the various enums you can pass to toString, thinking Qt::DefaultLocaleLongDate might look nicer to the user, can you try them and say what you think looks better?


- Albert Astals Cid


On Feb. 28, 2012, 4:29 a.m., Arjun Basu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6905/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2012, 4:29 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> In Kiriki, now there is an extra Date Field in the High Scores Dialog. Also the date is recorded whenever a new high score is generated.
> . This is in response to this bug report https://bugs.kde.org/show_bug.cgi?id=236656
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.cpp 1282152 
> 
> Diff: http://svn.reviewboard.kde.org/r/6905/diff/
> 
> 
> Testing
> -------
> 
> Yes, I have tested the changes and it is working perfectly.
> 
> 
> Screenshots
> -----------
> 
> The High Scores Dialog
>   http://svn.reviewboard.kde.org/r/6905/s/625/
> New High Score
>   http://svn.reviewboard.kde.org/r/6905/s/626/
> 
> 
> Thanks,
> 
> Arjun Basu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120228/ebc69cea/attachment.html>