[Kde-games-devel] Review Request: import TagaroAudio into libkdegames, port Granatier and KGoldRunner to use that copy instead

[Albert Astals Cid]

> On Feb. 13, 2012, 11:24 p.m., Albert Astals Cid wrote:
> > trunk/KDE/kdegames/libkdegames/audio/kgaudioscene-openal.cpp, line 103
> > <http://svn.reviewboard.kde.org/r/6902/diff/1/?file=47623#file47623line103>
> >
> >     As a developer using KGSound i'd like to get a way to get this and the other errors of this class up
> 
> Stefan Majewsky wrote:
>     I doubt it's worth the effort. I don't expect the OpenAL calls to fail in any sane environment, they're just there for completeness. And even if it fails... KgAudio targets games where the sound effects are not mission-critical, i.e. the game won't be completely unplayable without sounds. If the sound won't work, what are you going to do?
>     
>     I don't see any need to do any error analysis that's more detailed than kDebug(). If anybody wants an API for error retrieval, it can easily be added to KgSound later.
> 
> Parker Coates wrote:
>     At the very least, I think you should upgrade the kDebug()s to kWarning()s.
> 
> Stefan Majewsky wrote:
>     Parker has a point. I changed that before commiting.

Well, i want to know that something failed so I can inform my user, because my users don't read kWarnings since they are on a N9 and don't have a shell to read ;-)


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6902/#review10671
-----------------------------------------------------------


On Feb. 15, 2012, 12:34 a.m., Stefan Majewsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6902/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2012, 12:34 a.m.)
> 
> 
> Review request for KDE Games and Ian Wadham.
> 
> 
> Description
> -------
> 
> As the first new component in libkdegames v5, I'm adding TagaroAudio which has already resided in the kdegames source tree via private static copies in Granatier and KGoldRunner. This patch ports both to the new classes in libkdegames.
> 
> Because the Tagaro brand name need be eliminated as the code is imported into libkdegames, I have removed the Tagaro namespace and added a "Kg" prefix to the class names, which are now KgAudioScene and KgSound. I know that this is a departure from the current "KGameFoo" naming scheme, see my mail to the kde-games-devel@ about this.
> 
> I could not get reviewboard to accept my patch including the various files I deleted, so here's a list of all deleted stuff:
> * granatier/cmake/modules/FindSndFile.cmake (now in <toplevel>/cmake/modules)
> * granatier/src/TagaroAudio
> * granatier/src/granatiersound.{h,cpp} (Tagaro::Sound is now used directly instead of the thin wrapper GranatierSound)
> * kgoldrunner/cmake/modules/FindSndFile.cmake (see above; why did we have two copies of this anyway?)
> * kgoldrunner/src/TagaroAudio
> * kgoldrunner/src/kgrsoundbank.{h,cpp} (after I removed the ifdefs, it was not used anywhere, so I figured it's about time to retire this class).
> 
> I checked the log of the static copies of TagaroAudio in Granatier and KGoldRunner, and imported a patch from Mathias Kraus in granatier/src/Tagaro into the KgAudio code.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/CMakeLists.txt 1279940 
>   trunk/KDE/kdegames/cmake/modules/FindSndFile.cmake PRE-CREATION 
>   trunk/KDE/kdegames/granatier/CMakeLists.txt 1279940 
>   trunk/KDE/kdegames/granatier/src/CMakeLists.txt 1279940 
>   trunk/KDE/kdegames/granatier/src/game.h 1279940 
>   trunk/KDE/kdegames/granatier/src/game.cpp 1279940 
>   trunk/KDE/kdegames/kgoldrunner/CMakeLists.txt 1279940 
>   trunk/KDE/kdegames/kgoldrunner/src/CMakeLists.txt 1279940 
>   trunk/KDE/kdegames/kgoldrunner/src/kgoldrunner.cpp 1279940 
>   trunk/KDE/kdegames/kgoldrunner/src/kgrgame.h 1279940 
>   trunk/KDE/kdegames/kgoldrunner/src/kgrgame.cpp 1279940 
>   trunk/KDE/kdegames/kgoldrunner/src/kgrsounds.h 1279940 
>   trunk/KDE/kdegames/kgoldrunner/src/kgrsounds.cpp 1279940 
>   trunk/KDE/kdegames/kgoldrunner/src/main.cpp 1279940 
>   trunk/KDE/kdegames/libkdegames/CMakeLists.txt 1279940 
>   trunk/KDE/kdegames/libkdegames/audio/CMakeLists.txt PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/audio/check-libsndfile-capabilities.cpp PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/audio/kgaudioscene-openal.cpp PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/audio/kgaudioscene-phonon.cpp PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/audio/kgaudioscene.h PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/audio/kgopenalruntime_p.h PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/audio/kgsound-openal.cpp PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/audio/kgsound-phonon.cpp PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/audio/kgsound.h PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/includes/CMakeLists.txt 1279940 
>   trunk/KDE/kdegames/libkdegames/includes/KgAudioScene PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/includes/KgSound PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/6902/diff/
> 
> 
> Testing
> -------
> 
> Sound playback works in Granatier and KGoldRunner.
> 
> 
> Thanks,
> 
> Stefan Majewsky
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120215/9927ac34/attachment.html>