[Kde-games-devel] Review Request: import TagaroAudio into libkdegames, port Granatier and KGoldRunner to use that copy instead

[Ian Wadham]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6902/#review10676
-----------------------------------------------------------


I think you have deleted too much in KGoldrunner. My intention was, if OpenAL is not available at build time, to keep KGoldrunner silent and not compile *any* of the sound code. IOW I am deprecating the use of Phonon in KGoldrunner and am not willing for it to be built in indirectly because it is a "fallback" inside KgSound or KGAudioScene.

I am serious about this. Phonon makes my application sound terrible... KGoldrunner went for a whole release (KDE SC 4.6) with no sound because the sound produced by Phonon was so bad. I spent large parts of my time a year ago on the Phonon list trying to get answers, but in vain. Also no amount of re-building with more and more recent versions of KDE libs, Phonon, Phonon Backend, Qt or GStreamer made any improvement. Finally I switched to TagaroAudio and OpenAL and everything has worked fine ever since.

Perhaps the Granatier authors had similar experience with Phonon. They were the first to switch to TagaroAudio.

I think it is OK to delete the KGrSoundBank class in KGoldrunner, and any other references to Phonon, because I think it is unlikely that Phonon will improve regarding the playing of short sounds. We have been waiting four years for that at KDE Games, but performance has only got worse.

- Ian Wadham


On Feb. 13, 2012, 8:37 p.m., Stefan Majewsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6902/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2012, 8:37 p.m.)
> 
> 
> Review request for KDE Games and Ian Wadham.
> 
> 
> Description
> -------
> 
> As the first new component in libkdegames v5, I'm adding TagaroAudio which has already resided in the kdegames source tree via private static copies in Granatier and KGoldRunner. This patch ports both to the new classes in libkdegames.
> 
> Because the Tagaro brand name need be eliminated as the code is imported into libkdegames, I have removed the Tagaro namespace and added a "Kg" prefix to the class names, which are now KgAudioScene and KgSound. I know that this is a departure from the current "KGameFoo" naming scheme, see my mail to the kde-games-devel@ about this.
> 
> I could not get reviewboard to accept my patch including the various files I deleted, so here's a list of all deleted stuff:
> * granatier/cmake/modules/FindSndFile.cmake (now in <toplevel>/cmake/modules)
> * granatier/src/TagaroAudio
> * granatier/src/granatiersound.{h,cpp} (Tagaro::Sound is now used directly instead of the thin wrapper GranatierSound)
> * kgoldrunner/cmake/modules/FindSndFile.cmake (see above; why did we have two copies of this anyway?)
> * kgoldrunner/src/TagaroAudio
> * kgoldrunner/src/kgrsoundbank.{h,cpp} (after I removed the ifdefs, it was not used anywhere, so I figured it's about time to retire this class).
> 
> I checked the log of the static copies of TagaroAudio in Granatier and KGoldRunner, and imported a patch from Mathias Kraus in granatier/src/Tagaro into the KgAudio code.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/CMakeLists.txt 1279940 
>   trunk/KDE/kdegames/cmake/modules/FindSndFile.cmake PRE-CREATION 
>   trunk/KDE/kdegames/granatier/CMakeLists.txt 1279940 
>   trunk/KDE/kdegames/granatier/src/CMakeLists.txt 1279940 
>   trunk/KDE/kdegames/granatier/src/game.h 1279940 
>   trunk/KDE/kdegames/granatier/src/game.cpp 1279940 
>   trunk/KDE/kdegames/kgoldrunner/CMakeLists.txt 1279940 
>   trunk/KDE/kdegames/kgoldrunner/src/CMakeLists.txt 1279940 
>   trunk/KDE/kdegames/kgoldrunner/src/kgoldrunner.cpp 1279940 
>   trunk/KDE/kdegames/kgoldrunner/src/kgrgame.h 1279940 
>   trunk/KDE/kdegames/kgoldrunner/src/kgrgame.cpp 1279940 
>   trunk/KDE/kdegames/kgoldrunner/src/kgrsounds.h 1279940 
>   trunk/KDE/kdegames/kgoldrunner/src/kgrsounds.cpp 1279940 
>   trunk/KDE/kdegames/kgoldrunner/src/main.cpp 1279940 
>   trunk/KDE/kdegames/libkdegames/CMakeLists.txt 1279940 
>   trunk/KDE/kdegames/libkdegames/audio/CMakeLists.txt PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/audio/kgaudioscene-openal.cpp PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/audio/kgaudioscene-phonon.cpp PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/audio/kgaudioscene.h PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/audio/kgopenalruntime_p.h PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/audio/kgsound-openal.cpp PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/audio/kgsound-phonon.cpp PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/audio/kgsound.h PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/includes/CMakeLists.txt 1279940 
>   trunk/KDE/kdegames/libkdegames/includes/KgAudioScene PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/includes/KgSound PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/6902/diff/
> 
> 
> Testing
> -------
> 
> Sound playback works in Granatier and KGoldRunner.
> 
> 
> Thanks,
> 
> Stefan Majewsky
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120214/ab3cb9a8/attachment.html>