[Kde-games-devel] Review Request: remove KGGZ dependency from KBattleShip (aka Naval Battle)

[Paolo Capriotti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6895/#review10667
-----------------------------------------------------------


You removed too much. Multiplayer doesn't require GGZ libraries, and was there since before GGZ was integrated.

- Paolo Capriotti


On Feb. 8, 2012, 11:43 p.m., Stefan Majewsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6895/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2012, 11:43 p.m.)
> 
> 
> Review request for KDE Games and Paolo Capriotti.
> 
> 
> Description
> -------
> 
> As discussed on kde-games-devel@, I'm starting to remove KGGZ from kdegames. This patch drops all GGZ-related code from KBattleShip. I have been careful not to leave any unused (and thus untestable) code paths, so the patch has grown to a massive size of +46/-3082. The patch consists of 11 git-svn commits.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kbattleship/src/CMakeLists.txt 1278817 
>   trunk/KDE/kdegames/kbattleship/src/aientity.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/battlefield.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/battlefield.cpp 1278817 
>   trunk/KDE/kdegames/kbattleship/src/battlefieldview.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/battlefieldview.cpp 1278817 
>   trunk/KDE/kdegames/kbattleship/src/button.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/button.cpp 1278817 
>   trunk/KDE/kdegames/kbattleship/src/chatwidget.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/chatwidget.cpp 1278817 
>   trunk/KDE/kdegames/kbattleship/src/controller.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/controller.cpp 1278817 
>   trunk/KDE/kdegames/kbattleship/src/entity.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/entity.cpp 1278817 
>   trunk/KDE/kdegames/kbattleship/src/kbattleship.kcfg 1278817 
>   trunk/KDE/kdegames/kbattleship/src/kbattleship.protocol 1278817 
>   trunk/KDE/kdegames/kbattleship/src/kbattleshipui.rc 1278817 
>   trunk/KDE/kdegames/kbattleship/src/main.cpp 1278817 
>   trunk/KDE/kdegames/kbattleship/src/mainwindow.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/mainwindow.cpp 1278817 
>   trunk/KDE/kdegames/kbattleship/src/message.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/message.cpp 1278817 
>   trunk/KDE/kdegames/kbattleship/src/module.dsc 1278817 
>   trunk/KDE/kdegames/kbattleship/src/networkdialog.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/networkdialog.cpp 1278817 
>   trunk/KDE/kdegames/kbattleship/src/networkentity.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/networkentity.cpp 1278817 
>   trunk/KDE/kdegames/kbattleship/src/playerentity.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/playerentity.cpp 1278817 
>   trunk/KDE/kdegames/kbattleship/src/playfield.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/playfield.cpp 1278817 
>   trunk/KDE/kdegames/kbattleship/src/protocol.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/protocol.cpp 1278817 
>   trunk/KDE/kdegames/kbattleship/src/sea.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/sea.cpp 1278817 
>   trunk/KDE/kdegames/kbattleship/src/seaview.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/seaview.cpp 1278817 
>   trunk/KDE/kdegames/kbattleship/src/settings.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/settings.cpp 1278817 
>   trunk/KDE/kdegames/kbattleship/src/settings.kcfgc PRE-CREATION 
>   trunk/KDE/kdegames/kbattleship/src/settingsbase.kcfgc 1278817 
>   trunk/KDE/kdegames/kbattleship/src/simplemenu.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/simplemenu.cpp 1278817 
>   trunk/KDE/kdegames/kbattleship/src/uientity.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/welcomescreen.h 1278817 
>   trunk/KDE/kdegames/kbattleship/src/welcomescreen.cpp 1278817 
> 
> Diff: http://svn.reviewboard.kde.org/r/6895/diff/diff
> 
> 
> Testing
> -------
> 
> Played the game a few times, both with easy AI (to test winning) and hard AI (to test losing). Everything works fine.
> 
> 
> Thanks,
> 
> Stefan Majewsky
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120209/890287c0/attachment.html>