<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6895/">http://svn.reviewboard.kde.org/r/6895/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You removed too much. Multiplayer doesn't require GGZ libraries, and was there since before GGZ was integrated.</pre>
<br />
<p>- Paolo</p>
<br />
<p>On February 8th, 2012, 11:43 p.m., Stefan Majewsky wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games and Paolo Capriotti.</div>
<div>By Stefan Majewsky.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2012, 11:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As discussed on kde-games-devel@, I'm starting to remove KGGZ from kdegames. This patch drops all GGZ-related code from KBattleShip. I have been careful not to leave any unused (and thus untestable) code paths, so the patch has grown to a massive size of +46/-3082. The patch consists of 11 git-svn commits.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Played the game a few times, both with easy AI (to test winning) and hard AI (to test losing). Everything works fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdegames/kbattleship/src/CMakeLists.txt <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/aientity.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/battlefield.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/battlefield.cpp <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/battlefieldview.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/battlefieldview.cpp <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/button.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/button.cpp <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/chatwidget.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/chatwidget.cpp <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/controller.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/controller.cpp <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/entity.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/entity.cpp <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/kbattleship.kcfg <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/kbattleship.protocol <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/kbattleshipui.rc <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/main.cpp <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/mainwindow.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/mainwindow.cpp <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/message.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/message.cpp <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/module.dsc <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/networkdialog.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/networkdialog.cpp <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/networkentity.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/networkentity.cpp <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/playerentity.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/playerentity.cpp <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/playfield.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/playfield.cpp <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/protocol.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/protocol.cpp <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/sea.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/sea.cpp <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/seaview.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/seaview.cpp <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/settings.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/settings.cpp <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/settings.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/settingsbase.kcfgc <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/simplemenu.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/simplemenu.cpp <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/uientity.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/welcomescreen.h <span style="color: grey">(1278817)</span></li>
<li>trunk/KDE/kdegames/kbattleship/src/welcomescreen.cpp <span style="color: grey">(1278817)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6895/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>