[Kde-games-devel] Review Request: avoid a crash because of a negative area

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107739/#review23769
-----------------------------------------------------------


This review has been submitted with commit 08e0ec93940ca2da4f46bd277ecafeb5f7ffa772 by Jaime Torres to branch KDE/4.10.

- Commit Hook


On Dec. 15, 2012, 6:09 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107739/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2012, 6:09 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Avoid a crash starting kolf.
> The crash comes when the calculated area is <0, something impossible in R*R (only in C*C).
> The patch makes the area always >=0.
> 
> The patch is similar to what I proposed then, but I forgot how to use reviewboard for svn.
> 
> 
> This addresses bug 258998.
>     http://bugs.kde.org/show_bug.cgi?id=258998
> 
> 
> Diffs
> -----
> 
>   external/Box2D/Collision/Shapes/b2PolygonShape.cpp c96583b 
> 
> Diff: http://git.reviewboard.kde.org/r/107739/diff/
> 
> 
> Testing
> -------
> 
> before, the crash (yes, I still suffer it).
> after, kolf runs.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121220/159cba0c/attachment.html>