[Kde-games-devel] Review Request: Fix & improve kmines mouse actions

[Albert Astals Cid]

> On Dec. 16, 2012, 3:16 p.m., Albert Astals Cid wrote:
> > When pressing the middle mouse button the behaviour has changed, previously the square where the mouse was wasn't "down", while now it is. Is this on purspose?
> 
> Andrew Wallace wrote:
>     Yes this is intentional. Having the center square unpressed causes additional corner cases when the mouse is dragged partially of the playing field. I could have kept the behavior the same with more code but thought it not worthwhile.

To be honest i do not think this kind of behavioural change makes sense if we are speaking of doing a bugfix. A bugfix should fix bugs, not change how things work in the general case for the user.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107067/#review23539
-----------------------------------------------------------


On Dec. 15, 2012, 1:53 a.m., Andrew Wallace wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107067/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2012, 1:53 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> This does two things:
> 
> 1) Be safer about cleaning up visually 'pressing' squares.
> 2) Have a left click on a revealed square act the same as a middle click.
> 
> The patch changes how the mouse actions are handled. Storing what action is started with the mouse down event. Makes the logic more generic.
> 
> (Please be kind, it's my first patch.)
> 
> 
> This addresses bugs 221725 and 284952.
>     http://bugs.kde.org/show_bug.cgi?id=221725
>     http://bugs.kde.org/show_bug.cgi?id=284952
> 
> 
> Diffs
> -----
> 
>   minefielditem.h a6319d3 
>   minefielditem.cpp 3e77cc1 
> 
> Diff: http://git.reviewboard.kde.org/r/107067/diff/
> 
> 
> Testing
> -------
> 
> Testing was by hand, here are the cases I made sure to try and looked for press artifacts:
> 
> 1) Steps in bug 221725.
> 
> 2) Middle drag then right clicked on tool bar.
> 
> 3) Right down. Drag. Left down. Drag. Both release. (And vice versa.)
> 
> 4) Middle down. Drag off play area. Release. Left click anything.
> 
> 
> Thanks,
> 
> Andrew Wallace
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121216/38d5c593/attachment.html>