<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107067/">http://git.reviewboard.kde.org/r/107067/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 16th, 2012, 3:16 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When pressing the middle mouse button the behaviour has changed, previously the square where the mouse was wasn't "down", while now it is. Is this on purspose?</pre>
</blockquote>
<p>On December 16th, 2012, 11:26 p.m., <b>Andrew Wallace</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes this is intentional. Having the center square unpressed causes additional corner cases when the mouse is dragged partially of the playing field. I could have kept the behavior the same with more code but thought it not worthwhile.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To be honest i do not think this kind of behavioural change makes sense if we are speaking of doing a bugfix. A bugfix should fix bugs, not change how things work in the general case for the user.</pre>
<br />
<p>- Albert</p>
<br />
<p>On December 15th, 2012, 1:53 a.m., Andrew Wallace wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Andrew Wallace.</div>
<p style="color: grey;"><i>Updated Dec. 15, 2012, 1:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This does two things:
1) Be safer about cleaning up visually 'pressing' squares.
2) Have a left click on a revealed square act the same as a middle click.
The patch changes how the mouse actions are handled. Storing what action is started with the mouse down event. Makes the logic more generic.
(Please be kind, it's my first patch.)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing was by hand, here are the cases I made sure to try and looked for press artifacts:
1) Steps in bug 221725.
2) Middle drag then right clicked on tool bar.
3) Right down. Drag. Left down. Drag. Both release. (And vice versa.)
4) Middle down. Drag off play area. Release. Left click anything.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=221725">221725</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=284952">284952</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>minefielditem.h <span style="color: grey">(a6319d3)</span></li>
<li>minefielditem.cpp <span style="color: grey">(3e77cc1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107067/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>