[Kde-games-devel] Review Request: Fix & improve kmines mouse actions

[Andrew Wallace]

> On Dec. 13, 2012, 7:03 p.m., Albert Astals Cid wrote:
> > Hi, this patch mixes bug fixes and features right? (We don't have anyone very much knowledgeable in kmines at the moment, so sorry if i'm doing silly questions)

That is correct. All but one line is to fix the bugs. I threw the left click acting like middle click in as a bonus, but if we are in the wrong window for features it is trivial to yank back out into a separate patch.

The difference I'm talking about is:

if(midButtonPressed || (ev->button() == Qt::LeftButton && itemUnderMouse && itemUnderMouse->isRevealed() ))
{
   m_mouseAction = CLEAR_NEIGHBORS;
}

would be be only a bug fix if it were:

if(midButtonPressed)
{
   m_mouseAction = CLEAR_NEIGHBORS;
}


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107067/#review23430
-----------------------------------------------------------


On Nov. 2, 2012, 1:03 a.m., Andrew Wallace wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107067/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2012, 1:03 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> This does two things:
> 
> 1) Be safer about cleaning up visually 'pressing' squares.
> 2) Have a left click on a revealed square act the same as a middle click.
> 
> The patch changes how the mouse actions are handled. Storing what action is started with the mouse down event. Makes the logic more generic.
> 
> (Please be kind, it's my first patch.)
> 
> 
> This addresses bugs 221725, 260005 and 284952.
>     http://bugs.kde.org/show_bug.cgi?id=221725
>     http://bugs.kde.org/show_bug.cgi?id=260005
>     http://bugs.kde.org/show_bug.cgi?id=284952
> 
> 
> Diffs
> -----
> 
>   minefielditem.h a6319d3 
>   minefielditem.cpp 3e77cc1 
> 
> Diff: http://git.reviewboard.kde.org/r/107067/diff/
> 
> 
> Testing
> -------
> 
> Testing was by hand, here are the cases I made sure to try and looked for press artifacts:
> 
> 1) Steps in bug 221725.
> 
> 2) Middle drag then right clicked on tool bar.
> 
> 3) Right down. Drag. Left down. Drag. Both release. (And vice versa.)
> 
> 4) Middle down. Drag off play area. Release. Left click anything.
> 
> 
> Thanks,
> 
> Andrew Wallace
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121214/1e4a50a9/attachment.html>