[Kde-games-devel] Review Request: Fix crash due to calling GameView::gameOver inside GameView::startNewGame

[Michael Reeves]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/7013/
-----------------------------------------------------------

(Updated Aug. 21, 2012, 1:09 a.m.)


Review request for KDE Games.


Changes
-------

indentation fix on comment.


Description
-------

Attempt to fix crash due to null Map pointer. Prevents calling GameView::startNewGame or GameView::gameOver before GameView is fully ready the cause of my variant.

Crash is reproducable as of revision 1311053 in the 4.9 branch. Did not test master.


Diffs (updated)
-----

  /branches/KDE/4.9/kdegames/konquest/gameview.h 1311580 
  /branches/KDE/4.9/kdegames/konquest/gameview.cc 1311580 

Diff: http://svn.reviewboard.kde.org/r/7013/diff/


Testing
-------

*Built konquest from 4.9 svn head.
*Repeatly start new computer only game using only keyboard equivalants.
*Unpatched code intermiently crashes with attatched stack trace.
*Valgrind shows repeated invalid reads with the finally one leading to the crash. Relevant output is attatched.
I am unable to reproduce this after patching the code.


Thanks,

Michael Reeves

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120821/683cac96/attachment.html>