[Kde-games-devel] Review Request: Fix crash due to calling GameView::gameOver inside GameView::startNewGame

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/7013/#review10946
-----------------------------------------------------------


Also could you find better names for locked and gameOver or at least document what they are doing and what they are used fo?


/branches/KDE/4.8/kdegames/konquest/gameview.cc
<http://svn.reviewboard.kde.org/r/7013/#comment13555>

    Spacing is wrong
    
    To be honest i don't think this can happen



/branches/KDE/4.8/kdegames/konquest/gameview.cc
<http://svn.reviewboard.kde.org/r/7013/#comment13554>

    m_locked = false, here?


- Albert Astals Cid


On Aug. 19, 2012, 12:36 a.m., Michael Reeves wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/7013/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2012, 12:36 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Attempt to fix crash due to null Map pointer. Prevents calling GameView::startNewGame or GameView::gameOver before GameView is fully ready the cause of my variant.
> 
> Crash is reproducable as of revision 1311053 in the 4.9 branch. Did not test master.
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.8/kdegames/konquest/gameview.h 1308596 
>   /branches/KDE/4.8/kdegames/konquest/gameview.cc 1308596 
> 
> Diff: http://svn.reviewboard.kde.org/r/7013/diff/
> 
> 
> Testing
> -------
> 
> *Built konquest from 4.9 svn head.
> *Repeatly start new computer only game using only keyboard equivalants.
> *Unpatched code intermiently crashes with attatched stack trace.
> *Valgrind shows repeated invalid reads with the finally one leading to the crash. Relevant output is attatched.
> I am unable to reproduce this after patching the code.
> 
> 
> Thanks,
> 
> Michael Reeves
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120820/df30673d/attachment.html>