[Kde-games-devel] Review Request: Hard AI for KSquares

[Tom Vincent Peters]

> On April 29, 2012, 2:33 p.m., Albert Astals Cid wrote:
> > /trunk/KDE/kdegames/ksquares/src/gameboardscene.cpp, line 48
> > <http://svn.reviewboard.kde.org/r/6951/diff/2/?file=47928#file47928line48>
> >
> >     Why this change? Seems unrelated to the AI code

yes, this is not a required change for the ai. i put it there to get tooltips with the internal line index on free lines. that made understanding the debug output easier.


> On April 29, 2012, 2:33 p.m., Albert Astals Cid wrote:
> > /trunk/KDE/kdegames/ksquares/src/aicontroller.h, line 14
> > <http://svn.reviewboard.kde.org/r/6951/diff/2/?file=47926#file47926line14>
> >
> >     This include probably doesn't belong here, there's nothing in this header that needs a QSet, right?

That's right. I put it there because aicontroller.cpp uses QList but includes it in its header, so I thought I'd do the same with QSet.


> On April 29, 2012, 2:33 p.m., Albert Astals Cid wrote:
> > /trunk/KDE/kdegames/ksquares/src/ksquaresdemowindow.h, line 26
> > <http://svn.reviewboard.kde.org/r/6951/diff/2/?file=47930#file47930line26>
> >
> >     Is this change from 4 to 2 right?

No, it's wrong, I didn't change it back after I added the new cmdline argument players. When using KSquares in demo mode it will still default to 4 players.


> On April 29, 2012, 2:33 p.m., Albert Astals Cid wrote:
> > /trunk/KDE/kdegames/ksquares/src/ksquareswindow.cpp, line 349
> > <http://svn.reviewboard.kde.org/r/6951/diff/2/?file=47932#file47932line349>
> >
> >     Why is this commented out?

I commented it out because you could "cheat" by playing the game against the easy ai, then changing it to hard in the last moment and thus get a highscore entry in the "hard" category.


- Tom Vincent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6951/#review10780
-----------------------------------------------------------


On April 29, 2012, 2:07 p.m., Tom Vincent Peters wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6951/
> -----------------------------------------------------------
> 
> (Updated April 29, 2012, 2:07 p.m.)
> 
> 
> Review request for KDE Games and Matt Willliams.
> 
> 
> Description
> -------
> 
> Hard AI for KSquares
> Added per player AI difficulty	
> Moved AI settings from normal game to demo mode
> Added player count parameter for demo mode
> 
> known unintentional changes to other AI:
> medium AI probably will do hard-hearted handouts in most cases
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/ksquares/ChangeLog 1292133 
>   /trunk/KDE/kdegames/ksquares/src/aicontroller.h 1292133 
>   /trunk/KDE/kdegames/ksquares/src/aicontroller.cpp 1292133 
>   /trunk/KDE/kdegames/ksquares/src/gameboardscene.cpp 1292133 
>   /trunk/KDE/kdegames/ksquares/src/ksquares.kcfg 1292133 
>   /trunk/KDE/kdegames/ksquares/src/ksquaresdemowindow.h 1292133 
>   /trunk/KDE/kdegames/ksquares/src/ksquaresdemowindow.cpp 1292133 
>   /trunk/KDE/kdegames/ksquares/src/ksquareswindow.cpp 1292133 
>   /trunk/KDE/kdegames/ksquares/src/main.cpp 1292133 
>   /trunk/KDE/kdegames/ksquares/src/newgamewidget.ui 1292133 
>   /trunk/KDE/kdegames/ksquares/src/prefs_ai.ui 1292133 
>   /trunk/KDE/kdegames/ksquares/src/settings.kcfgc 1292133 
> 
> Diff: http://svn.reviewboard.kde.org/r/6951/diff/
> 
> 
> Testing
> -------
> 
> 100 autoplay games medium against hard
> a lot of games against hard ai
> 
> 
> Thanks,
> 
> Tom Vincent Peters
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120429/47323ff2/attachment-0001.html>