[Kde-games-devel] Review Request: Hard AI for KSquares

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6951/#review10780
-----------------------------------------------------------



/trunk/KDE/kdegames/ksquares/src/aicontroller.h
<http://svn.reviewboard.kde.org/r/6951/#comment13317>

    This include probably doesn't belong here, there's nothing in this header that needs a QSet, right?



/trunk/KDE/kdegames/ksquares/src/gameboardscene.cpp
<http://svn.reviewboard.kde.org/r/6951/#comment13319>

    Why this change? Seems unrelated to the AI code



/trunk/KDE/kdegames/ksquares/src/ksquaresdemowindow.h
<http://svn.reviewboard.kde.org/r/6951/#comment13321>

    Is this change from 4 to 2 right?



/trunk/KDE/kdegames/ksquares/src/ksquaresdemowindow.cpp
<http://svn.reviewboard.kde.org/r/6951/#comment13323>

    Remove empty spaces here



/trunk/KDE/kdegames/ksquares/src/ksquaresdemowindow.cpp
<http://svn.reviewboard.kde.org/r/6951/#comment13322>

    Why 15 to 10?



/trunk/KDE/kdegames/ksquares/src/ksquareswindow.cpp
<http://svn.reviewboard.kde.org/r/6951/#comment13320>

    Why is this commented out?



/trunk/KDE/kdegames/ksquares/src/main.cpp
<http://svn.reviewboard.kde.org/r/6951/#comment13324>

    The proper way of doing this is
    bool validPlayers;
    players = args->getOption("players").toInt(&validPlayers);


- Albert Astals Cid


On April 29, 2012, 2:07 p.m., Tom Vincent Peters wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6951/
> -----------------------------------------------------------
> 
> (Updated April 29, 2012, 2:07 p.m.)
> 
> 
> Review request for KDE Games and Matt Willliams.
> 
> 
> Description
> -------
> 
> Hard AI for KSquares
> Added per player AI difficulty	
> Moved AI settings from normal game to demo mode
> Added player count parameter for demo mode
> 
> known unintentional changes to other AI:
> medium AI probably will do hard-hearted handouts in most cases
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/ksquares/ChangeLog 1292133 
>   /trunk/KDE/kdegames/ksquares/src/aicontroller.h 1292133 
>   /trunk/KDE/kdegames/ksquares/src/aicontroller.cpp 1292133 
>   /trunk/KDE/kdegames/ksquares/src/gameboardscene.cpp 1292133 
>   /trunk/KDE/kdegames/ksquares/src/ksquares.kcfg 1292133 
>   /trunk/KDE/kdegames/ksquares/src/ksquaresdemowindow.h 1292133 
>   /trunk/KDE/kdegames/ksquares/src/ksquaresdemowindow.cpp 1292133 
>   /trunk/KDE/kdegames/ksquares/src/ksquareswindow.cpp 1292133 
>   /trunk/KDE/kdegames/ksquares/src/main.cpp 1292133 
>   /trunk/KDE/kdegames/ksquares/src/newgamewidget.ui 1292133 
>   /trunk/KDE/kdegames/ksquares/src/prefs_ai.ui 1292133 
>   /trunk/KDE/kdegames/ksquares/src/settings.kcfgc 1292133 
> 
> Diff: http://svn.reviewboard.kde.org/r/6951/diff/
> 
> 
> Testing
> -------
> 
> 100 autoplay games medium against hard
> a lot of games against hard ai
> 
> 
> Thanks,
> 
> Tom Vincent Peters
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120429/2905a5c2/attachment.html>