[Kde-games-devel] Review Request: Knetwalk rotation reduction

[Albert Astals Cid]

> On April 15, 2012, 4:22 p.m., Frederik Schwarzer wrote:
> > On a non-technical note ... Isn't it part of a dexterity game to be penalised for making wrong decisions or moves? Just a thought.
> 
> Ben Longbons wrote:
>     True, but the original reason I wrote this patch was because my mouse was double right-clicking when I didn't want it to (I could live with occasionally not remembering which click rotated which direction).
>     
>     That's why I didn't try to implement full undo support.
> 
> Frederik Schwarzer wrote:
>     I know I will cause some eye-rolling now but ... could this be an option? :D
>     Maybe having the fergiving mode as default and then having the option to play in strict mode where every click counts?
>

I'm with Frederik, the point of the game is to do it right from the start, if you rotate in the wrong direction that is to be penalized. I don't agree with this patch and if added should be an option and disabled by default.

The great question is who decides on this given we don't seem to have a knetwalk maintainer.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6935/#review10769
-----------------------------------------------------------


On April 8, 2012, 6:50 p.m., Ben Longbons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6935/
> -----------------------------------------------------------
> 
> (Updated April 8, 2012, 6:50 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> This knetwalk patch keeps track of the last cell edited and how it
> changed, so that suboptimal click sequences are not penalized.
> 
> * Left click + right click is equivalent to no click (useful if your
> middle mouse button by simultaneously clicking the other two and you
> hit them at different times)
> * 3 clicks is equivalent to a click in the opposite direction.
> * Special handling is applied for straight pipes -  any 2 clicks is
> equivalent to no click
> 
> Note that this is *not* general undo support, just mistake prevention
> and convenience for the single most recent cell.
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/knetwalk/src/fielditem.h 1287365 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/knetwalk/src/fielditem.cpp 1287365 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/knetwalk/src/mainwindow.h 1287365 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/knetwalk/src/mainwindow.cpp 1287365 
> 
> Diff: http://svn.reviewboard.kde.org/r/6935/diff/
> 
> 
> Testing
> -------
> 
> Tested against trunk, and also against 4.8.2 after changing the Kg::difficulty back to KGameDifficulty
> 
> (The first round of testing made me implement the special behavior for straight pipes)
> 
> 
> Thanks,
> 
> Ben Longbons
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120417/69ab6b07/attachment.html>