<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6935/">http://svn.reviewboard.kde.org/r/6935/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 15th, 2012, 4:22 p.m., <b>Frederik Schwarzer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On a non-technical note ... Isn't it part of a dexterity game to be penalised for making wrong decisions or moves? Just a thought.</pre>
</blockquote>
<p>On April 15th, 2012, 4:42 p.m., <b>Ben Longbons</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">True, but the original reason I wrote this patch was because my mouse was double right-clicking when I didn't want it to (I could live with occasionally not remembering which click rotated which direction).
That's why I didn't try to implement full undo support.</pre>
</blockquote>
<p>On April 17th, 2012, 8:32 a.m., <b>Frederik Schwarzer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I know I will cause some eye-rolling now but ... could this be an option? :D
Maybe having the fergiving mode as default and then having the option to play in strict mode where every click counts?
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm with Frederik, the point of the game is to do it right from the start, if you rotate in the wrong direction that is to be penalized. I don't agree with this patch and if added should be an option and disabled by default.
The great question is who decides on this given we don't seem to have a knetwalk maintainer.</pre>
<br />
<p>- Albert</p>
<br />
<p>On April 8th, 2012, 6:50 p.m., Ben Longbons wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Ben Longbons.</div>
<p style="color: grey;"><i>Updated April 8, 2012, 6:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This knetwalk patch keeps track of the last cell edited and how it
changed, so that suboptimal click sequences are not penalized.
* Left click + right click is equivalent to no click (useful if your
middle mouse button by simultaneously clicking the other two and you
hit them at different times)
* 3 clicks is equivalent to a click in the opposite direction.
* Special handling is applied for straight pipes - any 2 clicks is
equivalent to no click
Note that this is *not* general undo support, just mistake prevention
and convenience for the single most recent cell.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested against trunk, and also against 4.8.2 after changing the Kg::difficulty back to KGameDifficulty
(The first round of testing made me implement the special behavior for straight pipes)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/knetwalk/src/fielditem.h <span style="color: grey">(1287365)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/knetwalk/src/fielditem.cpp <span style="color: grey">(1287365)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/knetwalk/src/mainwindow.h <span style="color: grey">(1287365)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/knetwalk/src/mainwindow.cpp <span style="color: grey">(1287365)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6935/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>